Skip to content

gh-133810: remove http.server.CGIHTTPRequestHandler and --cgi flag #133811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 17, 2025
Merged

gh-133810: remove http.server.CGIHTTPRequestHandler and --cgi flag #133811

merged 19 commits into from
May 17, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented May 10, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 10, 2025
Closed
@picnixz
Copy link
Member Author

picnixz commented May 10, 2025

Free-threaded failure is known: #132983 (comment).

@picnixz picnixz mentioned this pull request May 11, 2025
Open
picnixz
picnixz commented May 11, 2025
View reviewed changes
@donBarbos donBarbos mentioned this pull request May 14, 2025
Merged
picnixz
picnixz commented May 16, 2025
View reviewed changes
picnixz
picnixz commented May 16, 2025
View reviewed changes
@picnixz picnixz requested a review from hugovk May 16, 2025 11:01
hugovk
hugovk reviewed May 16, 2025
View reviewed changes
@picnixz picnixz requested a review from hugovk May 16, 2025 15:28
@hugovk
Copy link
Member

hugovk commented May 16, 2025

Still some suggestions that GitHub is hiding about not bumping the __version__, and some unused imports in Lib/http/server.py.

picnixz and others added 2 commits May 16, 2025 17:31
hugovk
hugovk approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice cleanup! +28 −755

@picnixz
Copy link
Member Author

picnixz commented May 16, 2025

Thanks for the review! Sorry for this long back and forth but I was using GH UI :')

@hugovk
Copy link
Member

hugovk commented May 16, 2025

It's all good! 🚀

@picnixz picnixz self-assigned this May 16, 2025
@picnixz picnixz merged commit faac627 into python:main May 17, 2025
43 checks passed
@picnixz picnixz deleted the cleanup/315/remove-cgi-handler-133810 branch May 17, 2025 07:58
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz @Pranjal095
pythongh-133810: remove http.server.CGIHTTPRequestHandler and `--cg…
450c60b 
…i` flag (python#133811)

The CGI HTTP request handler has been deprecated since Python 3.13.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-133810: remove http.server.CGIHTTPRequestHandler and `--cg…
3fcec37 
…i` flag (python#133811)

The CGI HTTP request handler has been deprecated since Python 3.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @hugovk